fix: tsci push fallback to findBoardFiles when no entrypoint#3213
Open
LittleLemonDrop wants to merge 16 commits into
Open
fix: tsci push fallback to findBoardFiles when no entrypoint#3213LittleLemonDrop wants to merge 16 commits into
LittleLemonDrop wants to merge 16 commits into
Conversation
- Re-added hasWarnings tracking in build-file.ts, register.ts, exit-build.ts - Fixed exit code logic: 0=success, 1=errors, 2=warnings-only - Reverted test changes for boards that produce no diagnostics - build-ignore-drc-categories.test.ts correctly expects exit code 1
…oduce warnings on CI
Matches tsci dev behavior: when getEntrypoint returns null (no index.circuit.tsx, no mainEntrypoint), fall back to searching for board files in the project instead of silently returning undefined. Closes tscircuit#2797
LittleLemonDrop
force-pushed
the
fix/push-entrypoint-fallback
branch
from
e4efb9e to
5e96e10
Compare
Contributor
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches tsci dev behavior: when getEntrypoint returns null (no
index.circuit.tsx, no mainEntrypoint), fall back to searching for
board files in the project instead of silently continuing with
snippetFilePath=undefined.
Closes #2797